Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove piptools from dev deps #299

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

zacharis278
Copy link
Contributor

@zacharis278 zacharis278 commented Mar 25, 2024

pip tools and this constraint will conflict. Normally not an issue since the constraint doesn't apply to pip-tools.in but because we have dev depend on pip-tools in this repo the dev requirements are unable to compile (https://github.com/edx/portal-designer/actions/runs/8394856396/job/22992880471)

We should be able to run the requirements job again once this is merged

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (59d05fe) to head (7fbdce2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files          61       61           
  Lines        1208     1208           
  Branches      130      130           
=======================================
  Hits         1023     1023           
  Misses        160      160           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharis278 zacharis278 merged commit 14c24a8 into master Mar 26, 2024
7 checks passed
@zacharis278 zacharis278 deleted the zhancock/fix-upgrade-failures branch March 26, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants